[GitHub] [flink] swuferhong commented on a diff in pull request #20303: [FLINK-28599][table-planner] Adding FlinkJoinToMultiJoinRule to support translating left/right outer join to multi join

2022-08-06 Thread GitBox
swuferhong commented on code in PR #20303: URL: https://github.com/apache/flink/pull/20303#discussion_r939601228 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRuleTest.scala: ## @@ -50,19 +50,214 @@ class

[GitHub] [flink] swuferhong commented on a diff in pull request #20303: [FLINK-28599][table-planner] Adding FlinkJoinToMultiJoinRule to support translating left/right outer join to multi join

2022-08-03 Thread GitBox
swuferhong commented on code in PR #20303: URL: https://github.com/apache/flink/pull/20303#discussion_r937292379 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/MultiJoinOptimizeTest.scala: ## @@ -0,0 +1,170 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #20303: [FLINK-28599][table-planner] Adding FlinkJoinToMultiJoinRule to support translating left/right outer join to multi join

2022-08-03 Thread GitBox
swuferhong commented on code in PR #20303: URL: https://github.com/apache/flink/pull/20303#discussion_r936678209 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -0,0 +1,552 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #20303: [FLINK-28599][table-planner] Adding FlinkJoinToMultiJoinRule to support translating left/right outer join to multi join

2022-08-03 Thread GitBox
swuferhong commented on code in PR #20303: URL: https://github.com/apache/flink/pull/20303#discussion_r936495471 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRuleTest.scala: ## @@ -49,6 +49,36 @@ class

[GitHub] [flink] swuferhong commented on a diff in pull request #20303: [FLINK-28599][table-planner] Adding FlinkJoinToMultiJoinRule to support translating left/right outer join to multi join

2022-08-03 Thread GitBox
swuferhong commented on code in PR #20303: URL: https://github.com/apache/flink/pull/20303#discussion_r936487401 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -0,0 +1,552 @@ +/* + *