[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-20 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473711834 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -88,6 +88,7 @@ public Configuration

[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-20 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473709875 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java ## @@ -51,10 +51,7 @@ public boolean

[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473021574 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -88,6 +88,7 @@ public Configuration

[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r472914149 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -96,40 +97,51 @@ private int

[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r472866577 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -96,40 +97,51 @@ private int

[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r472863712 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -96,40 +97,51 @@ private int

[GitHub] [flink] tillrohrmann commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
tillrohrmann commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r472783027 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -96,40 +97,51 @@ private int