[GitHub] [flink] twalthr commented on a change in pull request #18108: [FLINK-25282][table-planner][table-runtime] Move every runtime dependency from planner to runtime

2021-12-15 Thread GitBox
twalthr commented on a change in pull request #18108: URL: https://github.com/apache/flink/pull/18108#discussion_r769789892 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/PaddingLeftMapFunction.java ## @@ -0,0 +1,52

[GitHub] [flink] twalthr commented on a change in pull request #18108: [FLINK-25282][table-planner][table-runtime] Move every runtime dependency from planner to runtime

2021-12-15 Thread GitBox
twalthr commented on a change in pull request #18108: URL: https://github.com/apache/flink/pull/18108#discussion_r769474228 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -448,14 +448,35 @@ object

[GitHub] [flink] twalthr commented on a change in pull request #18108: [FLINK-25282][table-planner][table-runtime] Move every runtime dependency from planner to runtime

2021-12-15 Thread GitBox
twalthr commented on a change in pull request #18108: URL: https://github.com/apache/flink/pull/18108#discussion_r769414851 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecIntervalJoin.java ## @@