wanglijie95 edited a comment on pull request #12754: URL: https://github.com/apache/flink/pull/12754#issuecomment-650017734
Hi @aljoscha , when I checked the implementation of `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger`, I was confused in two methods : `OnElement` and `clear`. First of all, I think that `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger` should also fire at the end of window. I saw that `ContinuousEventTimeTrigge` has registered a timer with `window.maxTimestamp()` in `OnElement` : https://github.com/apache/flink/blob/6227fffbe67c9ce4c5591ed1e940f6c34ee137bb/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java#L59 But I didn't find that in `ContinuousProcessingTimeTrigger.`. Secondly, I think that `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger` should delete the timer with `window.maxTimestamp()` in `clear`, but they didn't. Are the above bugs? Or some other considerations, I am a little confused. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
