wuchong commented on a change in pull request #11060:
[FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64
function
URL: https://github.com/apache/flink/pull/11060#discussion_r378015754
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -906,6 +906,10 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"FROM_BASE64('5L2g5aW9')",
"你好"
)
+
+ testSqlApi(
+ "FROM_BASE64(CAST(x'6147567362473867643239796247513D' AS VARBINARY))",
+ "hello world")
Review comment:
Could you add 2 more tests here?
```
testSqlApi(
"FROM_BASE64(x'6147567362473867643239796247513D')",
"hello world")
testSqlApi(
"FROM_BASE64(f58)", ==> add an additional column whose value is
"5L2g5aW9".getBytes(StandardCharsets.UTF_8)
"你好")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
