[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-08-05 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-518150476 Yes. It looks good from my side. Thanks for the help @twalthr .

[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-07-29 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-516254901 Hi @XuPingyong , #9185 and #9203 is merged. I think we can resume this PR. Could you rebase and re-generate the config html?

[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-07-22 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-514029686 @twalthr Sure. It makes sense to continue this before we reach a consensus.

[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-07-22 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-513681169 Thanks for the updating. It looks good to me now. @twalthr do you want to have a look at the Configuration page?

[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-07-19 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-513146074 I think we need to refactor the config page. I wrote a draft for this and pushed the commit to my repo:

[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-07-16 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-512082259 Hi @zentol do you want to have a look again? I think the `TableMeta` annotation is great to generate a good SQL configuration