[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-516249435 Thanks for the reviewing @godfreyhe , I will modify them when merging because they are

[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-515659009 Hi @JingsongLi @godfreyhe , I have updated the pull request to adapt blink planner to

[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-515054911 Thanks @twalthr . I will adapt blink planner to the new config names then.

[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-515051523 Thanks for the reviewing @godfreyhe . I have updated the PR. @twalthr do you want to

[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-514639784 Thanks for the feedbacks. I have update the config names again. Welcome to have

[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-514511313 Hi @twalthr , I agree we should keep config names short. However, IMO, 4 levels is too

[GitHub] [flink] wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

wuchong commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-514502935 FLINK-13266 is just merged. We will keep the conflicts to make the reviewing easier.