[GitHub] [flink] wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner

2019-08-08 Thread GitBox
wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9377#issuecomment-519503862 Merged with commits: 28260cdd70aee0a4169a068887feae71a81ec4c0 e8fd892220f6575ef9

[GitHub] [flink] wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner

2019-08-08 Thread GitBox
wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9377#issuecomment-519495140 Thanks @JingsongLi for the reviewing. The travis failed on an unrelated case whic

[GitHub] [flink] wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner

2019-08-07 Thread GitBox
wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9377#issuecomment-519345696 Thanks @JingsongLi for the reviewing. I have updated the PR. I think the commit message

[GitHub] [flink] wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner

2019-08-07 Thread GitBox
wuchong commented on issue #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9377#issuecomment-519131198 CI passed in my own travis: https://travis-ci.org/wuchong/flink/builds/568707905 ---