[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector

2020-11-09 Thread GitBox
wuchong commented on pull request #13214: URL: https://github.com/apache/flink/pull/13214#issuecomment-723966883 Hi @pyscala , thanks for the updating and sorry for the late reviewing. I helped to improve the code and will merge it once build is passed.

[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector

2020-10-09 Thread GitBox
wuchong commented on pull request #13214: URL: https://github.com/apache/flink/pull/13214#issuecomment-705956351 Hi @pyscala , thanks for the updating. However, the new added `discoverOptionalFactory` method still no generic method for all kinds of fatories. What I mean was that

[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector

2020-10-08 Thread GitBox
wuchong commented on pull request #13214: URL: https://github.com/apache/flink/pull/13214#issuecomment-705956351 Hi @pyscala , thanks for the updating. However, the new added `discoverOptionalFactory` method still no generic method for all kinds of fatories. What I mean was that