[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-09-01 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-910214808 The failed test is tracked by FLINK-24096. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-09-01 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909334534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-09-01 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909952281 Thanks @RocMarshal for the updating. I appended a commit to clean some code. Will merge it if you don't have objections and the build is passed. -- This is an automated

[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909334534 Thanks for the updating @RocMarshal , however, please do not squash commits when you addressing review comments. Otherwise, reviewer can't find what is changed since last time

[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-908087936 @RocMarshal Please do not use "git merge" to rebase branches, otherwise the changes is hard to track. Please use "git rebase" instead. IntelliJ IDEA provide an easy tool to do