[GitHub] [flink] xintongsong commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
xintongsong commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1004004779 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherImpl.java: ## @@ -148,102 +156,106 @@ private void fetchMetrics()

[GitHub] [flink] xintongsong commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
xintongsong commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1003232260 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java: ## @@ -50,9 +50,7 @@ import

[GitHub] [flink] xintongsong commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
xintongsong commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1003232260 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java: ## @@ -50,9 +50,7 @@ import