xuyang1706 commented on issue #9300: [FLINK-13513][ml] Add the FlatMapper and
related classes for later al…
URL: https://github.com/apache/flink/pull/9300#issuecomment-545722380
> Hi @xuyang1706 @becketqin Thanks for the discussion and sorry for the late
response. This PR currently seems
xuyang1706 commented on issue #9300: [FLINK-13513][ml] Add the FlatMapper and
related classes for later al…
URL: https://github.com/apache/flink/pull/9300#issuecomment-545309543
> Also, just curious what about the `FlatMapper` classes? Do we still want
them?
Thanks for your advice,
xuyang1706 commented on issue #9300: [FLINK-13513][ml] Add the FlatMapper and
related classes for later al…
URL: https://github.com/apache/flink/pull/9300#issuecomment-544931164
> @xuyang1706 Thanks for the patch. The structure and semantic in the patch
seems a little confusing to me. I
xuyang1706 commented on issue #9300: [FLINK-13513][ml] Add the FlatMapper and
related classes for later al…
URL: https://github.com/apache/flink/pull/9300#issuecomment-536423593
> Hi @xuyang1706
> Thanks for you PR. I have left only one minor comment, please look it if
you have time.
xuyang1706 commented on issue #9300: [FLINK-13513][ml] Add the FlatMapper and
related classes for later al…
URL: https://github.com/apache/flink/pull/9300#issuecomment-536423068
> thanks for the update @xuyang1706 and sorry for the late reply. Overall I
think the change looks good to me.
xuyang1706 commented on issue #9300: [FLINK-13513][ml] Add the FlatMapper and
related classes for later al…
URL: https://github.com/apache/flink/pull/9300#issuecomment-533404154
> Thanks for the contribution @xuyang1706 . I took a quick look and I think
there are some confusions I have
