[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-27 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057502548 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057502548 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057502548 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057499949 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -532,27 +468,30 @@ public

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057486097 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057486097 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057486097 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057476274 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/util/SqlGatewayRestClientAndEndpointUtils.java: ## @@ -0,0 +1,138 @@ +/* + *