[GitHub] [flink] zentol commented on pull request #16345: [FLINK-18783] Load AkkaRpcSystem through separate classloader

2021-07-08 Thread GitBox
zentol commented on pull request #16345: URL: https://github.com/apache/flink/pull/16345#issuecomment-876245791 > Conceptually, the RpcService should be self-contained in the sense that it has all the classes it needs to know. The ContextClassLoader business is surprisingly little

[GitHub] [flink] zentol commented on pull request #16345: [FLINK-18783] Load AkkaRpcSystem through separate classloader

2021-07-02 Thread GitBox
zentol commented on pull request #16345: URL: https://github.com/apache/flink/pull/16345#issuecomment-873088656 > Could we add it as provided into the test scope (so Maven has to build it for test execution) and then extract the path from it? That's how I'd approach this issue in gradle

[GitHub] [flink] zentol commented on pull request #16345: [FLINK-18783] Load AkkaRpcSystem through separate classloader

2021-07-02 Thread GitBox
zentol commented on pull request #16345: URL: https://github.com/apache/flink/pull/16345#issuecomment-873005029 > Alternatively, we introduce a new folder submodule in flink-dist, similar to plugins. yes, I also thought about having a separate location in dist for production