zentol commented on PR #22738: URL: https://github.com/apache/flink/pull/22738#issuecomment-1590991638
> Ok, with that one I'm wondering how you identified all the places where the parameter should be set. For Java 17 we have to add `add-opens/add-exports` JVM arguments for any reflection usage to work. Tests that failed indirectly told me where other JVMs are being created. Each modified line will be later accompanied by the opens/exports arguments. If any of these is missing `IgnoreUnrecognizedVMOptions` then the tests fail on Java 8 (because it doesn't know what to do with --add-opens). If any created JVM is missing both arguments then the chances are high that the tests fail on Java 17 (if they dont then they dont need it, and who are we to complain there :shrug: ). > I struggle to find a way to look for any location where we might have missed this flag (e.g. looking for a specific string). The "proof" that I'm covering everything (that needs it) is the fact that the tests are passing in the [Java 17 WIP branch](https://dev.azure.com/chesnay/flink/_build/results?buildId=3606&view=results). (well except python but that's a separate issue I believe). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
