[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-09-19 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-533194969 Yes, it is better to merge this PR soon if no other concerns. Because there

[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-09-09 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-529754407 Thanks for the review and good suggestions @1u0 ! I agree that `pull`

[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-09-02 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-527070252 Thanks for the notification and I already rebased the master. It is freiendly

[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-28 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-525999658 Thanks for the further review. The failure compilation is caused by

[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-27 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-525565847 Thanks for the review @pnowojski ! I have submitted the fixup commit

[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-27 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-525236060 @pnowojski this pr is ready for review and I have not changed the