[GitHub] [flink] zhijiangW commented on pull request #12912: [FLINK-18595][network] Fix the deadlock issue by task thread and canceler thread in RemoteInputChannel

zhijiangW commented on pull request #12912: URL: https://github.com/apache/flink/pull/12912#issuecomment-664800187 Thanks for review @rkhachatryan and @curcur , merging! This is an automated message from the Apache Git

[GitHub] [flink] zhijiangW commented on pull request #12912: [FLINK-18595][network] Fix the deadlock issue by task thread and canceler thread in RemoteInputChannel

zhijiangW commented on pull request #12912: URL: https://github.com/apache/flink/pull/12912#issuecomment-661684125 > For the second point, I mean if the cleanup of channels (sort by channel id for example) in the same order in the two threads, would that resolve the deadlock problem as

[GitHub] [flink] zhijiangW commented on pull request #12912: [FLINK-18595][network] Fix the deadlock issue by task thread and canceler thread in RemoteInputChannel

zhijiangW commented on pull request #12912: URL: https://github.com/apache/flink/pull/12912#issuecomment-660785430 @curcur Re 2. I did not get your point here. Can you explain it a bit? Re 3. this interface was changed after release-1.11, this PR is based on release-1.10 fix. For

[GitHub] [flink] zhijiangW commented on pull request #12912: [FLINK-18595][network] Fix the deadlock issue by task thread and canceler thread in RemoteInputChannel

zhijiangW commented on pull request #12912: URL: https://github.com/apache/flink/pull/12912#issuecomment-659316266 I considered some options to resolve this issue: 1. Get ride of canceler thread completely to avoid race condition issue in SingleInputGate and respective channel, by