zjuwangg opened a new pull request #11848:
URL: https://github.com/apache/flink/pull/11848


   ## What is the purpose of the change
   
   * Now TypeMappingUtils#checkPhysicalLogicalTypeCompatible method doesn't 
consider the different physical and logical type validation logic of source and 
sink: logical type should be able to cover the physical type in source, but 
physical type should be able to cover the logic type in sink vice verse. 
Besides, the decimal type should be taken more carefully, when target type is 
Legacy(Decimal), it should be able to accept any precision decimal type.*
   * This pr aims to solve the above problem.*
   
   
   ## Brief change log
   
     - 9b24a40 correct the validation logc
   
   ## Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to