[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866939928 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected Flink

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866939928 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected Flink

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866938596 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -173,6 +174,16 @

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866938313 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6 +220,2