[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
wangyang0918 commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1120146932 Your explanation makes sense to me. Given that it is the designed behavior, I have no more question now. I just feels like if the job finished(e.g. batch jobs)

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
wangyang0918 commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1120140585 I have done some manual tests. And it works well for recover the missing deployment. I have last one question which need to be discussed more. When `SHUTDOWN_O

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
wangyang0918 commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1119769786 If you do not mind, I will do some manual tests tomorrow and share the feedback then. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

2022-05-06 Thread GitBox
wangyang0918 commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1119380750 I am getting to this PR and try to give it a pass very soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t