[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-13 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133514787 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133236486 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133237792 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133237792 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133236486 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-10 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133042094 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-10 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133042094 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-10 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1130430131 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/IntegrateWithServableTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-08 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1130375623 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/ExampleStages.java: ## @@ -110,6 +111,10 @@ public static SumModel load(StreamTableEnvironment tEnv, String

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-04 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1125428753 ## flink-ml-core/src/main/java/org/apache/flink/ml/builder/PipelineModel.java: ## @@ -82,6 +85,33 @@ public static PipelineModel load(StreamTableEnvironment tEnv,