[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-27 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1447626627 Thanks @zhipeng93 @Fanoid @jiangxin369 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-27 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1447612921 > Hi, I just found we have made this change. I have a question: how do we obtain the corresponding input stream for each GraphNode in the GraphModel? modelDataInputs are linearly

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-22 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1441314725 @zhipeng93 Thanks for the review. Can you help take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1439531423 @zhipeng93 Can you help review this PR? If this PR looks good to you, I will need to send an email to the FLIP-289 voting thread to discuss the proposed API change (e.g. let

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1439477023 @jiangxin369 Thanks for the review. Can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1438134181 @jiangxin369 Can you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to