[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1118206725 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[]

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-22 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1115302692 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[]

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-21 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1112795550 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[]

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-21 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1112795550 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[]