[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-18 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169735419 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -152,41 +155,52 @@ private static DataStream cacheBroadcastVariables(

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-18 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169539973 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,13 +182,16 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-18 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169539973 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,13 +182,16 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169464509 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169459719 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169459719 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169459719 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168219732 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,83 +144,39 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168137985 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,138 +200,162 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168210187 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,138 +200,162 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168219732 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,83 +144,39 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168219732 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,83 +144,39 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168210187 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,138 +200,162 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168137985 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,138 +200,162 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168137985 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,138 +200,162 @@ private

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168135056 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -468,7 +425,9 @@ public void

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168127178 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -152,41 +155,52 @@ private static DataStream cacheBroadcastVariables(

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168127178 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -152,41 +155,52 @@ private static DataStream cacheBroadcastVariables(

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168127178 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -152,41 +155,52 @@ private static DataStream cacheBroadcastVariables(

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-16 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168127178 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -152,41 +155,52 @@ private static DataStream cacheBroadcastVariables(