[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788380094 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestEntry.java ## @@ -38,6 +38,7 @@ priva

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788377304 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java ## @@ -0,0 +1,376 @@ +/*

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788375580 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788375174 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788374933 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r787408231 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java ## @@ -0,0 +1,53 @@ +/* + * Licensed