subject:"\[GitHub\] \[flink\-table\-store\] JingsongLi commented on a diff in pull request #305\: \[FLINK\-28256\] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite"

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-11 Thread GitBox

JingsongLi commented on code in PR #305: URL: https://github.com/apache/flink-table-store/pull/305#discussion_r992981418 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/WriteFunction.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-07 Thread GitBox

JingsongLi commented on code in PR #305: URL: https://github.com/apache/flink-table-store/pull/305#discussion_r990578854 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWrite.java: ## @@ -52,4 +56,35 @@ RecordWriter