SteNicholas commented on code in PR #554:
URL: https://github.com/apache/flink-table-store/pull/554#discussion_r1118344187


##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -218,6 +218,12 @@
             <td><p>Enum</p></td>
             <td>Specify the scanning behavior of the source.<br /><br 
/>Possible values:<ul><li>"default": Determines actual startup mode according 
to other table properties. If "scan.timestamp-millis" is set the actual startup 
mode will be "from-timestamp", and if "scan.snapshot-id" is set the actual 
startup mode will be "from-snapshot". Otherwise the actual startup mode will be 
"latest-full".</li><li>"latest-full": For streaming sources, produces the 
latest snapshot on the table upon first startup, and continue to read the 
latest changes. For batch sources, just produce the latest snapshot but does 
not read new changes.</li><li>"full": Deprecated. Same as 
"latest-full".</li><li>"latest": For streaming sources, continuously reads 
latest changes without producing a snapshot at the beginning. For batch 
sources, behaves the same as the "latest-full" startup 
mode.</li><li>"compacted-full": For streaming sources, produces a snapshot 
after the latest compaction on the table upon first st
 artup, and continue to read the latest changes. For batch sources, just 
produce a snapshot after the latest compaction but does not read new 
changes.</li><li>"from-timestamp": For streaming sources, continuously reads 
changes starting from timestamp specified by "scan.timestamp-millis", without 
producing a snapshot at the beginning. For batch sources, produces a snapshot 
at timestamp specified by "scan.timestamp-millis" but does not read new 
changes.</li><li>"from-snapshot": For streaming sources, continuously reads 
changes starting from snapshot specified by "scan.snapshot-id", without 
producing a snapshot at the beginning. For batch sources, produces a snapshot 
specified by "scan.snapshot-id" but does not read new changes.</li></ul></td>
         </tr>
+        <tr>
+            <td><h5>scan.plan-sort-partition</h5></td>
+            <td style="word-wrap: break-word;">false</td>
+            <td>Boolean</td>
+            <td>Whether to sort plan files by partition fields, this allows 
you to read according to the partition order, even if your partition writes are 
out of order.</td>

Review Comment:
   It's better to explain the usage case of the `scan.plan-sort-partition` to 
avoid the user misunderstand the usage of this option and note that there is no 
difference between `scan.plan-sort-partition=true` and `order by [partition 
field]` in batch mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to