[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134714232 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/utils/SimpleReadBuffer.java: ## @@ -0,0 +1,43 @@ +/* + * Copyright 2015 LinkedIn

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134713621 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134711088 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134708812 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134702880 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/LookupStoreReader.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134703041 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/LookupStoreWriter.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache