tsreaper commented on a change in pull request #11:
URL: https://github.com/apache/flink-table-store/pull/11#discussion_r786480063
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/CompactManager.java
##########
@@ -75,7 +75,8 @@ public void submitCompaction(Levels levels) {
return;
}
boolean dropDelete =
- unit.outputLevel() >=
levels.nonEmptyHighestLevel();
+ unit.outputLevel() != 0
+ && unit.outputLevel() >=
levels.nonEmptyHighestLevel();
Review comment:
add comments to explain the logic (for example level 0 is special
because key ranges from different files may overlap, and that compaction are
based on runs instead of files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
