[GitHub] [flink-table-store] zjureel commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

2022-11-17 Thread GitBox
zjureel commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026103960 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -90,6 +90,22 @@ public boolean snapshotExists(long

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

2022-11-17 Thread GitBox
zjureel commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026091394 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -90,6 +90,22 @@ public boolean snapshotExists(long

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

2022-11-17 Thread GitBox
zjureel commented on code in PR #388: URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026084973 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -90,6 +90,22 @@ public boolean snapshotExists(long