[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r699187127 ## File path: hourly-tips/src/main/java/org/apache/flink/training/exercises/hourlytips/HourlyTipsExercise.java ## @@ -56,8 +55,8 @@ public

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r699187127 ## File path: hourly-tips/src/main/java/org/apache/flink/training/exercises/hourlytips/HourlyTipsExercise.java ## @@ -56,8 +55,8 @@ public

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r699192091 ## File path: rides-and-fares/src/test/java/org/apache/flink/training/exercises/ridesandfares/RidesAndFaresIntegrationTest.java ## @@ -0,0 +1,91 @@ +/*

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r699191949 ## File path: rides-and-fares/src/test/java/org/apache/flink/training/exercises/ridesandfares/RidesAndFaresIntegrationTest.java ## @@ -0,0 +1,91 @@ +/*

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r699187127 ## File path: hourly-tips/src/main/java/org/apache/flink/training/exercises/hourlytips/HourlyTipsExercise.java ## @@ -56,8 +55,8 @@ public

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r698359197 ## File path: rides-and-fares/src/main/java/org/apache/flink/training/exercises/ridesandfares/RidesAndFaresExercise.java ## @@ -18,68 +18,119 @@

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r698320553 ## File path: common/src/test/java/org/apache/flink/training/exercises/testing/ComposedRichCoFlatMapFunction.java ## @@ -0,0 +1,70 @@ +package

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r697212832 ## File path: rides-and-fares/src/main/java/org/apache/flink/training/exercises/ridesandfares/RidesAndFaresExercise.java ## @@ -18,68 +18,122 @@

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r695684798 ## File path: common/src/test/java/org/apache/flink/training/exercises/testing/TestSink.java ## @@ -0,0 +1,26 @@ +package

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r695473786 ## File path: common/src/test/java/org/apache/flink/training/exercises/testing/ComposedKeyedProcessFunction.java ## @@ -0,0 +1,77 @@ +package

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r694703353 ## File path: long-ride-alerts/src/solution/java/org/apache/flink/training/solutions/longrides/LongRidesSolution.java ## @@ -71,36 +109,53 @@ public

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r694702114 ## File path: long-ride-alerts/src/main/java/org/apache/flink/training/exercises/longrides/LongRidesExercise.java ## @@ -18,62 +18,96 @@ package

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r694696407 ## File path: common/build.gradle ## @@ -17,6 +17,10 @@ dependencies { shadow

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r692839241 ## File path: common/src/test/java/org/apache/flink/training/exercises/testing/TestSink.java ## @@ -0,0 +1,26 @@ +package