HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-464962219
@fhueske
I finished rebase lastest upstream master just now. The compile error
probably comes from the generated avro classe
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-462017703
@fhueske
Thanks for the review. I removed all of unused fields, main function and
test cases. To have better code coverage,
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-451798255
@fhueske I refined test cases. Would you please take a last round of review?
---
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-445726623
@fhueske
Thanks for pointing out so many missing parts. As you pointed out, I added
SqlTypeInfo conversion and enforce List
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-441920259
@fhueske
I removed timestamp override, and also update the failure recovery test case
to test recovery reading file with 10
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-441301540
@fhueske
Resolved all of the comments except the one for timestamp rewrite. It is
needed for time field of window functions.
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737854
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737642
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737615
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737590
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737558
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737523
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737481
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737461
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737435
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-431737413
@fhueske
Thanks for your patient review. It is pretty helpful to make the PR more
readable and flawless. Resolved your comme
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-429517418
@fhueske
Add unit test for failure recovery logic. Please review it again after the
travis check turns to green.
--
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-429234463
@fhueske
Thanks for the review. Resolved all of the comments except unit tests for
the checkpointing logic
1) For the qu
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-428462374
@fhueske
Resolved most of your comments. The major blocker is probably the splittable
processing of Parquet files. It will p
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-428274826
@fhueske
Thanks for reviewing this PR. I can't agree more on offering a similar
experience for both input formats (Parquet a
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-421894204
@lvhuyen
For the Array handling issue, I figured it out. it is a List back
compatibility issue. When I do internal testing a
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-420872269
@lvhuyen
Last fix should resolve the problem you met in PoJoInputFormat. Would you
please try it out. For primitive array ha
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-420505649
@lvhuyen
Thanks for the quick patch. I think the data conversion should be handled in
RowConverter. I will ship a fix tonigh
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-419613742
@lvhuyen
Thanks for digging out the root cause. I guess I should pass the logic type
into RowPrimitiveConverter. So that dif
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-418951266
@lvhuyen
Thanks for using parquet input format and give me feedback. So the type
timstamp is logic type in parquet. It is in
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-416702085
@docete @fhueske
To make a clean interface for filterable parquet input format, I needs add
lots of code in this PR. After c
HuangZhenQiu commented on issue #6483: [Flink-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-414184561
@walterddr @suez1224
Fixed Rong's comments. Please continue with the review process at your most
convenient time.
-
HuangZhenQiu commented on issue #6483: [Flink-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#issuecomment-410152524
@suez1224 Would you please have a look this PR?
This is an aut
28 matches
Mail list logo
