[GitHub] StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-26 Thread GitBox
StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-424788457 Concerning the other method you mentioned: That one is never used on the critical path, so things may be different there.

[GitHub] StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-20 Thread GitBox
StephanEwen commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423270421 This is on the performance critical path. Can we solve this another way that does not involve additional branches?