[GitHub] StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client

2018-11-27 Thread GitBox
StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client URL: https://github.com/apache/flink/pull/7170#issuecomment-442109065 Looks good, +1 This is an automated message from the Apach

[GitHub] StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client

2018-11-27 Thread GitBox
StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client URL: https://github.com/apache/flink/pull/7170#issuecomment-442082770 Keeping a "compile" dependency is good for user dependency management. Let's got with the list of includes then, because

[GitHub] StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client

2018-11-25 Thread GitBox
StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client URL: https://github.com/apache/flink/pull/7170#issuecomment-441473526 +1 to the idea, but we should do it differently. If you want the Avro dependency not in the shaded jar, simply set it