[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-10-18 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-430986516 Thanks for the pick-up @GJL ! This is an automated message from the Apache

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-28 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-425415727 @uce I understand your concerned and sorry to involve you here. This is an

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-28 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-425333772 @lzqdename From my side this pull request goes the right direction and now it is ready to be merged. However, I am not a committer

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-410494126 cc @twalthr @StephanEwen This is an automated message from the Apache Git

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-410489497 @lzqdename thanks for your PR! this change makes sense. you could pay attention to the code style by looking at code around, and it