[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-07-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1517 CI tests are passing. I've been testing Gelly algorithms with this without error. I will merge this ... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-07-10 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/1517 > Reading back through the discussion I see that there are many ideas for future performance enhancements. If not already suggested I'd like to consider skipping staging for fixed length records.

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-06-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1517 +1 with just a few superficial comments. Reading back through the discussion I see that there are many ideas for future performance enhancements. If not already suggested I'd like to

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-06-19 Thread aalexandrov
Github user aalexandrov commented on the issue: https://github.com/apache/flink/pull/1517 @ggevay :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-06-18 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/1517 I have rebased to the current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-06-01 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/1517 Hi @fhueske, Thanks for the comments, I think I have addressed all of them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your