Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2108
Changes look good to me @rmetzger :-) I had only some minor comments. +1
for merging after addressing the comments.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2108
Thank you for your review @tillrohrmann and @zentol . I tried addressing
all your concerns.
Please let me know what you think about it.
---
If your project is set up for it, you can reply to
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2108
Good work @rmetzger. Well documented code and a good idea to solve the
problem. I had some comments concerning concurrent accesses to `pendingRecords`
and test stability on Travis. Once we've
Github user eliaslevy commented on the issue:
https://github.com/apache/flink/pull/2108
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2108
Thank you for the review @eliaslevy!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
