Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
Rebased to latest master. Merging this once Travis passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
Thanks for the review! Although the changes in `DelimitedInputFormat` don't
break the API according to the API Maven plugin, we can simply deprecate the
existing method and call the new method from it. T
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2123
Very good work Max! The changes look good to me and I think it's much
cleaner this way. The `DelimitedInputFormat` API change question needs to be
addressed before merging I think.
Regarding the
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
Brief summary of changes:
- fail if config couldn't be loaded
- make globalconfiguration non-global and remove static SINGLETON
- remove duplicate api methods
- remove undocumented XML
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
That's odd. I was working on exactly these changes and have just pushed
them (without seeing your comment before).
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2123
Looks like a good fix for now.
I would eventually really like to get rid of the `GlobalConfiguration`
singleton - it causes issues with embedding, testing, and encourages to not
cleanly
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2123
This problem sounds like it might cause very hard to debug problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
