[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2017-01-26 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2153 Yup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2017-01-26 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2153 OK, let's close this then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2017-01-26 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2153 I agree. There's a recent example of a user who suggested the same thing:

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2017-01-24 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2153 Now that some time has passed, I feel like we should really cover this in the docs first. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-08-18 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2153 Yes, the joda-time exclusion is independent. I just experienced that this has been an issue for our users multiple times. I'll update the tests to test the `SocketTextStreamWordCount`.

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-07-04 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2153 +1 to what Till and Jamie said. Regarding the removed joda-time exclusion: that's independent of the testing skeleton, right? --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-06-27 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2153 What I would like to see here is that the tests in the quickstart actually test the code from the job in the quickstart. For example if the job in the quickstart is WordCount it would be nice to

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2153 I think these tests are far too specific for the quickstarts. Why starting your own Flink cluster when the local execution environment would do the same? People using the quickstarts should not

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-06-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2153 This will be very helpful! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled