[GitHub] flink issue #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2219 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2219 The changes look good to me. Thanks for your work @zentol :-) I only had a minor comment whether we should allow users to use a string as metric scope delimiter. Apart from that, +1

[GitHub] flink issue #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-11 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2219 * rebased * added documentation for new key * replaced getScopeString() with getMetricIdentifier(String metricName) * getMetricIdentifier generates the fully qualified metric name *