Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2225
Just realized that the `byte[] recordKey` and `String partitionKey` are
actually the same only in different form, so now we have duplicate info in the
deser schema. I think we can keep the `String`
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2225
I fixed the remaining comments. I'll merge the changes tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2225
Good points on not using Amazon's `Shard` and `Record`, did not think of
that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2225
I added the javadoc and did some other changes:
- Commented out the `isEndOfStream()` method, because its not respected.
- Re-ordered the arguments of the deser schema. The first group is
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2225
Btw, should we also be adding the info from `Record#getPartitionKey()` to
the deserialization schema too? Might be off the scope of this issue, but might
as well now that we're on to this?
---
If
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2225
LGTM, +1 to merge the change after travis turns green + minor Javadoc
update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
