Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
Hi, I have updated the PR as @StephanEwen suggested, adding two new methods
named socketTextStream that take string delimiter as parameter and delegating
the old method to the new one
---
If your
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2233
ok, go ahead then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2233
Yes, `@PublicEvolving` allows us to change things, but it is still nice for
users if we give them a smooth transition :-)
---
If your project is set up for it, you can reply to this email and
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
Hi @zentol , If you agree with @StephanEwen 's suggestion, I will update
this PR in his way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2233
@StephanEwen The socketTextStream methods are already marked as
`@PublicEvolving`, i thought changing those was allowed?
---
If your project is set up for it, you can reply to this email and have
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2233
Because this breaks the public API, it would be good to do the following:
Add a new method to the `StreamExecutionEnvironment`, rather than changing
the old method. Tag that new method
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
Hi @zentol , thanks for your comments. I have updated this PR. Please let
me know if there are further improvements that need to be done.
---
If your project is set up for it, you can reply to this
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2233
Only had 2 small comments, otherwise this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
This is my first pull request to Flink. Any comments would be very
appreciative.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
