[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 I'm merging the change ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2236 couldn't find any problem, +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 I fixed the failing build and addressed all comments so far ;) (I was working on the code while you've reviewed it ) --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 Thank you for the review @zentol. I addressed all your comments and added metrics for committed offsets as well (I talked to the user who requested this feature and they requested this

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2236 You can rebase on top of #2237. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 This will simplify this PR: https://issues.apache.org/jira/browse/FLINK-4206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your