[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-09-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2294 Sorry for the late reply @greghogan. +1 from me as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-09-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2294 @fhueske what is your analysis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-08-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2294 This is okay to merge from my side. Definitely seems easier than the `Delegate` trick. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-08-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2294 The alternatives are much more hacky. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-08-01 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2294 This would replace `Delegate` and is much simpler. I placed it in the Java API package but it would not be visible to users through the `DataSet` API. The ultimate goal is to implicitly

[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-08-01 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2294 @greghogan I am not sure I completely understand this. If I see it correctly, the no-op operator is in the API, but gets removed during the translation? It looks like a bit of a hacky

[GitHub] flink issue #2294: [FLINK-4265] [dataset api] Add a NoOpOperator

2016-07-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2294 @StephanEwen thoughts on how to proceed? Not looking to rush this. With this simple PR I can remove the use of javassist's `ProxyFactory` from Gelly. Or we can defer consideration of this