[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

2016-08-05 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2333 IMHO, the offset should not be added to `TimeWindow`. It is only the assigners that would shift the start time/end time of a window. This way, other parts of the code don't need to be aware of

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

2016-08-04 Thread aditivin
Github user aditivin commented on the issue: https://github.com/apache/flink/pull/2333 Hi, Only the relevant changes are now visible. Pasting the details from the previous pull request (#2331) here: Added offset parameter for the following processing time window

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

2016-08-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2333 Hi, it doesn't help to just rebase it. I think you need to take the changes to the relevant files and create a new commit from that since the commit you have here contains a lot of other