Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks for addressing my comments! Looks very good. I'm sorry I asked
whether you have tested the changes. It may seem natural to you but trust me
that is not always the case :)
Merging...
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
And remember that my ultimate goal is not to host that image but that we
can convert it into an official one.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
Of course, who do you think I am :P
You can check a ready to run build here in case you don't want to test that
one. But it is true that we need some kind of automatized tests for the image.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks! Looks good. Did you run the changes with Docker?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
@mxm this should be ready now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
We should maybe wait for 1.1.1 to be up before doing this merge, I will add
the commit for this and probably rebase everything once it is ready. Is it ok ?
---
If your project is set up for it, you
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks for the PR! It would be nice to have the install path configurable.
Also, we should use ASF's load balancing script for downloading the binaries.
---
If your project is set up for it, you can
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
I added two additional changes, an extra security fix (default user is not
root now) and I changed the path to the more appropriate /opt.
Now this should be ready for review/merge.
---
If your
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
(notice than when I said need to improve I refer at the missing automation
to change the default release version on the Dockerfile).
---
If your project is set up for it, you can reply to this
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
I referred to the older FLINK issue since this is something we need to
still improve. I can try to fix it in a subsequent PR, do you have any hints of
how can we achieve this ?
R: @aljoscha
10 matches
Mail list logo
