[GitHub] flink issue #2401: [FLINK-4443][rpc] Add support in RpcCompletenessTest for ...

2016-08-23 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2401 Great @wenlong88. Changes look good to me. Will merge your PR. Thanks a lot for your contribution :-) Please close the PR after I've merged it. --- If your project is set up for it, you can

[GitHub] flink issue #2401: [FLINK-4443][rpc] Add support in RpcCompletenessTest for ...

2016-08-22 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/2401 @tillrohrmann all comments addressed. I have removed the `NativeMethod` annotation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2401: [FLINK-4443][rpc] Add support in RpcCompletenessTest for ...

2016-08-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2401 Thanks for your contribution @wenlong88. Your changes look good to me. I only had a comment concerning the `NativeMethod` annotation. I think that at the moment we could get along without it by