[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-10-04 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2560 @wuchong I heavily tested this PR again as it could introduce difficult bugs. And I also found one issue that needs to be discussed. If you have an expression like `CAST(TRUE AS VARCHAR) || 'Test'`

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2560 @twalthr I add some Table API tests but skip some tests doesn't supported in Table API, such as `NULLIF`, `IN`, `EXTRACT` --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2560 Thanks for updating the PR @wuchong. I found a little bug, but I will fix it myself and merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2560 Hi @twalthr , I have updated this PR , could you have a look again ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2560 I will shepherd this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes