[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter

2016-12-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2617 @StephanEwen, no worries about deferring this. Performance is nice but scaling and stability certainly takes precedence. Just wanted to make sure there was ample time between review and release.

[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter

2016-12-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2617 @greghogan I am quite deep into some large scale deployment and scalability issues right now. I plan to write a mail to the mailing list on that, actually. If possible, I'd like to defer

[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter

2016-11-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2617 Hi @StephanEwen, should we endeavor to get this into 1.2 or defer to the next release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter

2016-10-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2617 I have started like to take a look at this... The `FixLegthRecordSorter` and its interactions with the serializers / comparators was not very well tested before, hence not activated. I