Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
OK thanks. I addressed one last issue with shutting down the watch dog
thread (it was lingering around sleeping and only noticed that the task has
terminated after that sleep... now the task canceler
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2652
+1 go ahead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
OK, I would like to go ahead and merge this if there are no objections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2652
Concerning the Kafka test: From the logs, the test fails because a topic
cannot be deleted. The ZooKeeper operation blocks and test times out. I am
pretty sure that this is unrelated, as no
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
Travis gives the green light except for a Kafka failure. @StephanEwen
@rmetzger Do you know whether this is a known issue? Or might it be a
regression from this change?
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
Haha, that picture convinced me to actually add the test :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2652
Yeah, this sort of covers it. Just afraid of such a situation here:
https://twitter.com/thepracticaldev/status/687672086152753152
---
If your project is set up for it, you can reply to this
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
We have the `TaskManagerProcessReapingTest` which tests that the
TaskManager process properly exits when the TaskManager actor dies. In
addition, there is `TaskManagerTest#testTerminationOnFatalError`,
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2652
What do you think about a followup test, where we ensure that a fatal error
notification on the TaskManager actually results in a process kill?
---
If your project is set up for it, you can
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
Renamed the `TaskOptions` class to `TaskManagerOptions` so that we can
easily migrate the task manager options as a follow up.
---
If your project is set up for it, you can reply to this email and
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2652
Should we have one class `TaskManagerOptions`? To not spread the config
over too many classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2652
Thanks for the valuable feedback. Some of the errors were a little sloppy
on my side. Sorry for that. I addressed all your comments.
---
If your project is set up for it, you can reply to this email
12 matches
Mail list logo
